WORK-509
ID:WORK-509Status:done

Plugin translation bundles + mergePlugins() wiring

Give plugins a slot to ship their own translations and wire it into the merge so a configured locale resolves plugin-scoped keys. This is the mechanism first-party and community plugins both use.

Priority:mediumComplexity:moderateMilestone:v0.29.0Source:SPEC-035
main View source

Criteria completion

Criteria completion: 4 of 4 (100%) checked; history from Jul 17 to Jul 230%25%50%75%100%Jul 17Jul 23

Relationships

Implements 1
Related 3
Branches 2
main current done
claude/milestone-v0-29-0-stzywk doneclaude/multi-language-support-spec-5zzt9q ready
History 3
  1. f198cbc
    • ☑ `Plugin.translations` exists and is loaded/merged by `mergePlugins()`.
    • ☑ A plugin-shipped `de` bundle localizes that plugin's labels under `locale: 'de'`.
    • ☑ Site-level `strings` override beats the plugin bundle; missing keys fall to English.
    • ☑ No per-plugin default-language fallback path exists.
    by bjornolofandersson
  2. 9c7bd86
    Created (ready)by bjornolofandersson
  3. d92ad0c
    Content editedby Claude
    plan: accept SPEC-035, add v0.29.0 milestone + i18n work breakdown

Scope

  • Add translations?: Record<string, Record<string, LocalizedValue>> to Plugin (packages/types/src/package.ts), keyed by BCP 47 locale. Authored as per-locale JSON imported into the field (Decision D3/D8).
  • Thread translations through LoadedPlugin and MergedPluginResult, and in mergePlugins() (packages/runes/src/plugins.ts) select the bundle for the configured locale (with the D5 de-AT→de tag fallback) and merge into the LocaleContext.strings.
  • Enforce the D5 precedence at merge/resolve time: site ThemeConfig.strings entries win over plugin defaults; no per-plugin "default language" (English is the floor).
  • Tests: plugin bundle selected by locale, site override beats plugin bundle, unknown locale → English.

Acceptance Criteria

  • Plugin.translations exists and is loaded/merged by mergePlugins().
  • A plugin-shipped de bundle localizes that plugin's labels under locale: 'de'.
  • Site-level strings override beats the plugin bundle; missing keys fall to English.
  • No per-plugin default-language fallback path exists.

Blocked by

  • WORK-502

References

  • SPEC-035 — Plugin Translation Bundles, Decisions D3/D5/D8.

Resolution

Completed: 2026-07-17

Branch: claude/milestone-v0-29-0-stzywk

What was done

  • Added Plugin.translations (packages/types/src/package.ts) + PluginLocalizedValue; exported from the types index.
  • mergePlugins() aggregates per-locale bundles across plugins into MergedPluginResult.translations (plugin-scoped keys → no collisions); added selectPluginStrings(merged, locale) with the D5 de-AT→de fallback.
  • assembleThemeConfig gained locale / pluginTranslations / coreTranslations inputs and builds config.strings with Decision-D5 precedence: core bundle → plugin bundles → site ThemeConfig.strings (site wins), stamping config.locale.
  • Added SiteConfig.locale + SiteConfig.strings; the CLI loadMergedConfig threads them + merged.translations into assembleThemeConfig, so extract/inspect are locale-aware.
  • Tests: packages/runes/test/plugin-translations.test.ts (6) — aggregation, locale selection + fallback, site-wins, core-lowest, unknown-locale → English.

Notes

  • No per-plugin default language: an untranslated key resolves to English at the call site, never to another locale. 1560 transform+runes tests green.