Validate property and ref name uniqueness in createComponentRenderable

main View source

Relationships

ID:ADR-008Status:accepted

Framework-native component interface for rune overrides

Date:2026-04-04

main current done

claude/file-naming-convention-LJdwR done changeset-release/main done

Apr 21, 01:46 PMe900a90
Created (done)by bjornolofandersson
Apr 12, 10:26 AM1676387
Content editedby Claude
Apr 10, 06:58 PMf262d7b
Content editedby Claude
Apr 4, 02:28 PMc435d57
statusready→done
by Claude
Apr 4, 01:29 PMdca6250
Content editedby Claude
Apr 4, 11:43 AMece282c
Created (ready)by Claude
Add work items WORK-117 through WORK-122 for ADR-008 implementation

Summary

Add a static validation step to createComponentRenderable that checks for naming collisions between properties keys and refs keys. Since ADR-008 uses a flat namespace where both properties and refs become component props/slots, duplicate names would cause silent overwrites.

Acceptance Criteria

createComponentRenderable throws a descriptive error if any key appears in both properties and refs
Error message includes the rune name and the colliding key(s)
All existing runes pass validation (no current collisions)
Unit test for collision detection
Unit test confirming no false positives on valid runes

Approach

In packages/runes/src/lib/component.ts, add a Set intersection check between Object.keys(properties) and Object.keys(refs) before building the renderable
Throw with rune name and colliding keys if intersection is non-empty

Resolution

Completed: 2026-04-04

Branch: claude/adr-008-implementation-nBN9K

What was done

Added Set intersection validation in packages/runes/src/lib/component.ts
Fixed 3 pre-existing collisions: bento-cell icon (renamed property to iconSource), faction/realm name (removed from properties, kept as ref only)
9 unit tests in packages/runes/test/component.test.ts

Notes

Validation runs before attribute decoration, catching collisions at build time
All 1969 existing tests pass after fixing the 3 collisions