WORK-102
ID:WORK-102Status:done

Migrate complex runes from Model to createContentModelSchema

Migrate the remaining runes that have custom processChildren overrides with stateful parsing, text pattern matching, or DOM surgery. All will use the custom content model type.

Priority:highComplexity:complexMilestone:v1.0.0Source:SPEC-032
main View source

Criteria completion

Criteria completion: 8 of 8 (100%) checked; history from Apr 2 to Apr 30%25%50%75%100%Apr 2Apr 3

Relationships

Implements 1
Related 3
Branches 3
main current done
claude/file-naming-convention-LJdwR donechangeset-release/main doneclaude/align-sidenav-styling-4MuxV done
History 5
  1. e900a90
    Created (done)by bjornolofandersson
  2. f262d7b
    Content editedby Claude
  3. f0a845a
    • ☑ `form` rewritten using `createContentModelSchema` with `custom` content model
    • ☑ `conversation` rewritten using `createContentModelSchema` with `custom` content model
    • ☑ `tabs` rewritten using `createContentModelSchema` with `custom` content model
    • ☑ `bento` rewritten using `createContentModelSchema` with `custom` content model
    • ☑ `comparison` rewritten using `createContentModelSchema` with `custom` content model
    • ☑ `refrakt inspect <rune> --type=all` output is identical before and after for each rune
    • ☑ All existing tests pass — especially form, tabs, and conversation tests which cover edge cases
    • ☑ No Model class import remains in any of the migrated files
    by Claude
  4. a20f532
    statusready→done
    by Claude
  5. 5c72bef
    Created (ready)by Claude
    Add work items WORK-099 through WORK-104 for legacy Model removal

Runes

RuneLocationChallenge
formpackages/runes/src/tags/form.tsMulti-pass field parser with type inference from names, blockquote/list pattern detection, placeholder parsing, heading-to-fieldset conversion
conversationpackages/runes/src/tags/conversation.tsBlockquote-to-message conversion, speaker name extraction from bold text, alternating alignment
tabspackages/runes/src/tags/tabs.tsHeading-to-tab conversion, image extraction from heading content, header/tab content separation
bentorunes/marketing/src/tags/bento.tsIcon paragraph extraction via descendant tag filtering, size/span tier detection, DOM surgery separating icons from body
comparisonrunes/marketing/src/tags/comparison.tsRow type detection (check/cross/negative/text), bold label extraction, separator detection/removal, table structure mapping

Acceptance Criteria

  • form rewritten using createContentModelSchema with custom content model
  • conversation rewritten using createContentModelSchema with custom content model
  • tabs rewritten using createContentModelSchema with custom content model
  • bento rewritten using createContentModelSchema with custom content model
  • comparison rewritten using createContentModelSchema with custom content model
  • refrakt inspect <rune> --type=all output is identical before and after for each rune
  • All existing tests pass — especially form, tabs, and conversation tests which cover edge cases
  • No Model class import remains in any of the migrated files

Approach

Each rune's processChildren logic moves into the custom content model's processChildren function. The key difference is the return type — instead of setting instance properties via @group, the function returns a resolved fields object that the transform function receives.

Per-rune notes

  • form: The field parser state machine (type inference, blockquote detection, placeholder parsing) moves wholesale into processChildren. This is the largest single migration.
  • conversation: Speaker extraction from bold text and alternating alignment tracking move to processChildren. Relatively contained.
  • tabs: Heading content walking and image node extraction move to processChildren. The heading-to-tab tag reconstruction needs careful handling.
  • bento: The descendant tag filtering (icon paragraph detection) and body/icon separation move to processChildren. Size tier detection stays in transform.
  • comparison: Row type detection, label extraction, and separator removal move to processChildren. Table structure mapping stays in transform.

Dependencies

  • WORK-099 (simple core runes migrated)
  • WORK-101 (moderate runes migrated — validates the custom pattern on storyboard first)

References

  • SPEC-032 (parent spec)