WORK-341
ID:WORK-341Status:ready

Dark-mode token parity audit

Make dark-mode token coverage deliberate. Most "dark looks off" reports trace to the phantom tokens fixed in WORK-340 (a phantom can't have a dark value); this item closes the genuine remaining gaps and records the intentional shared-token decisions.

Priority:mediumComplexity:simpleMilestone:v0.19.0
main View source

Criteria completion

Criteria completion: 0 of 4 (0%) checked; tracking started on Jun 5, no incremental history yet0%25%50%75%100%Jun 5Jun 15

Tracking started Jun 5 — check back for trends.

Relationships

Related 2
Branches 4
main current ready
changeset-release/main doneclaude/v0.19-lumina-polish doneclaude/v0.19-milestone-planning readymain ready

Acceptance Criteria

  • The three code-block tokens with no dark override get correct dark values: --rf-color-line-highlight, --rf-color-line-highlight-rail, --rf-color-line-number. Verify line highlighting + numbering read correctly on a dark code block.
  • Every remaining semantic colour token defined in base.css either has a dark override in dark.css or is explicitly annotated as intentionally shared.
  • The --rf-color-primary-50…950 ramp is no longer a parity concern (removed by WORK-340); confirm nothing dark-mode-relevant still depends on it.
  • A light/dark spot-check (or snapshot) of code blocks, callouts, and badges shows no cold/blown-out colours.

Approach

Diff the base vs dark token sets (comm -23). For each unmatched token, add a dark value or annotate it shared. The code-block tokens are the only confirmed visual gap; the rest is a deliberate-decision pass once WORK-340's phantoms are resolved.

References

  • packages/lumina/tokens/base.css, dark.css
  • packages/lumina/styles/runes/codegroup.css + code/syntax styling